gregandClaude Opus 5.5
98ba043bec
Booting drafts as deployed catches a server that stops when a setting is empty, but the server's own output rarely says why, so the model guessed (more memory) for three rounds and the draft ended as WIP. When a draft fails with its defaults and has blank password-like settings without x-generate, the builder boots it once more with those filled. If that boot passes, the cause is certain, and the model is told exactly that: these settings stop the server when empty; give them x-generate (a password per server) or a working default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
80 lines
2.7 KiB
Go
80 lines
2.7 KiB
Go
package main
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestBootFailureKeepsVerdictAndServerOutput(t *testing.T) {
|
|
out := "[boot-test] deploying boottest-example (cm2network/steamcmd)\n" +
|
|
"[boot-test] container started; waiting for ready pattern /Server ready/\n" +
|
|
"[boot-test] FAILED: container exited before it was ready\n" +
|
|
"---- last 2 log lines ----\n" +
|
|
"Unknown argument --save-dir\n" +
|
|
"Usage: example_server ...\n"
|
|
got := bootFailure(out)
|
|
if !strings.Contains(got, "failed: FAILED: container exited before it was ready") {
|
|
t.Errorf("verdict missing: %s", got)
|
|
}
|
|
if !strings.Contains(got, "Unknown argument --save-dir") || strings.Contains(got, "deploying boottest") {
|
|
t.Errorf("want only the server's last lines, got: %s", got)
|
|
}
|
|
if v := bootVerdict("[boot-test] PASSED: READY: Server ready"); v != "PASSED: READY: Server ready" {
|
|
t.Errorf("verdict = %q", v)
|
|
}
|
|
}
|
|
|
|
func TestOutsideDirsSkipsSteamNoise(t *testing.T) {
|
|
r := &bootReport{ContainerChanges: []string{
|
|
"A /home/steam/.config/example-game/worlds/w.db",
|
|
"A /home/steam/Steam/logs/connection_log.txt",
|
|
"C /home/steam/.steam/registry.vdf",
|
|
}}
|
|
got := outsideDirs(r)
|
|
if len(got) != 1 || got[0] != "/home/steam/.config/example-game/worlds" {
|
|
t.Errorf("got %v", got)
|
|
}
|
|
if outsideDirs(nil) != nil {
|
|
t.Error("nil report should have no dirs")
|
|
}
|
|
}
|
|
|
|
func TestVariantNotes(t *testing.T) {
|
|
v := variant{Title: "Crossplay", Description: "PC + Xbox", StartupHint: "./example_server -crossplay", Ports: []string{"30000/udp"}}
|
|
got := variantNotes(v, "needs Xbox")
|
|
for _, want := range []string{"variant: Crossplay (PC + Xbox)", "documented startup: ./example_server -crossplay", "30000/udp", "the admin asked for: needs Xbox"} {
|
|
if !strings.Contains(got, want) {
|
|
t.Errorf("missing %q in %q", want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBlankRequiredLookingSettings(t *testing.T) {
|
|
dir := t.TempDir()
|
|
game := filepath.Join(dir, "example")
|
|
os.MkdirAll(game, 0o755)
|
|
os.WriteFile(filepath.Join(game, "game.yaml"), []byte(`id: example
|
|
defaultConfig:
|
|
JoinPassword: ""
|
|
AdminPassword: ""
|
|
ServerPassword: set-by-default
|
|
ServerName: x
|
|
configSchema:
|
|
properties:
|
|
JoinPassword: {type: string}
|
|
AdminPassword: {type: string, x-generate: {type: password}}
|
|
ServerPassword: {type: string}
|
|
ServerName: {type: string}
|
|
`), 0o644)
|
|
got := blankRequiredLooking(dir, "example")
|
|
if len(got) != 1 || got[0] != "JoinPassword" {
|
|
t.Errorf("got %v, want only JoinPassword (AdminPassword is generated, ServerPassword has a default)", got)
|
|
}
|
|
msg := emptySettingsProblem(got, "FAILED: server crashed")
|
|
if !strings.Contains(msg, "stops when JoinPassword is empty") || !strings.Contains(msg, `"x-generate": {"type": "password"}`) {
|
|
t.Errorf("message: %s", msg)
|
|
}
|
|
}
|