feat(builder): research, build and a worker for the AI builder #6
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gbreed-public/gbr-games#6
Reference in new issue
Block a user
The AI builder as code in this repo instead of n8n workflows: a self-hosted model does the drafting, real boots check the facts, and every result is a pull request that CI validates and boot-tests like any other. See BUILDER.md.
Commands
research -name N: SearXNG search → reads the best pages with a reader → the model lists the server's variants (images, Steam app, startup, ports, notes, sources) → every image (docker manifest inspect) and Steam app (anonymoussteamcmd +app_info_print, on the isolated network) is checked before an admin sees it.build -name N -variant @v.json: first boot of each candidate image, skipping images that need root (imageUnusable) →draft→ the draft deployed with the node-agent'sBootTest(the same check as CI) → crashes, error lines and saves still written outside/servergo back to the same model conversation, three boots at most.worker: polls the panel's builder queue (outbound only), runs research/build in a fresh clone, streams output as the job log (heartbeat; the panel can cancel), opensdraft/<id>-<job>as a PR from the bot account;WIP:if it never booted.Also:
Dockerfile.builderand.gitea/workflows/builder-image.yml(publishesgbr-builder:latestwhencmd/changes). All configuration is environment variables; deployment files are kept outside this public repo.draft's loop now lives in adrafterthat keeps the conversation, sobuildcan feed boot failures back.Checked for real:
research -name Valheimfound Steam app 896660 ("Valheim Dedicated Server", verified), three images (all exist), ports 2456–2457/udp, and-crossplay.buildwith that variant rejected lloesche and community-valheim-tools within seconds (both need root) and continued with cm2network/steamcmd. The full build result follows in a comment.🤖 Generated with Claude Code
Here's some quick feedback on your PR:
dcb07cfed7toc75190d8c4feat(builder): research, build and a worker for the AI builder on our own hardwareto feat(builder): research, build and a worker for the AI builderHere's some quick feedback on your PR:
openPR(worker.go), the Gitea bot token is passed as agit -c http.extraHeader=Authorization: token <TOKEN>CLI argument, exposing it in the process table (/proc/*/cmdline,ps) to any local user.build()(build.go),res.Problems = nilafter a successful first-boot selection silently discards the diagnostic reasons why earlier candidate images failed, losing useful context for the PR reviewer.POST /jobs/{id}/resultis only logged and the worker moves on; the expensive build result is lost with no retry or local persistence, so the panel never learns the outcome.End-to-end build: Valheim (
research→build, run by hand, not through the worker yet)lloesche/valheim-serverandcommunity-valheim-tools/valheim-serverwere rejected after 3 s each (they need root,groupmod: Permission denied). It went on withcm2network/steamcmdand Steam app 896660.~/.config/unity3d/IronGate/Valheim, outside the volume). Round 2 passed the text checks.Loading: Done). But the second boot showed the server still writing worlds outside/server, and that went back to the model. This is the case text checks alone missed last time./server(it setHOME=/server). Done in 3 model rounds and 2 boots.The result is a template with crossplay on by default, 2456–2457/udp, a measured
readyPattern, and settings for name, password, world, crossplay and port.What a reviewer would still have to catch (why it ends in a PR):
-name ${SERVER_NAME}inside an unquoted$ARGSgets split into words: "GBRHosting - My Server" reaches Valheim as just "GBRHosting".GamePortis editable, butdefaultPortsstays 2456–2457, so changing it would break joins.Both look like good next deterministic checks (word-split startup arguments; port settings that don't match
defaultPorts).Here's some quick feedback on your PR:
🤖 AI Code Review
⚠️ The review feedback was empty or could not be generated.
Automated review by AI Git Bot
Two problems a draft can boot fine with but break once an owner changes a setting, both in the builder's Valheim draft: - splitSettings: text settings used unquoted on the command line, directly or through ARGS="-name ${SERVER_NAME}"; ./server $ARGS, so "GBRHosting - My Server" reaches the game as several arguments. Suggests quoting or a bash array. - portSettings: game-port settings whose default isn't in defaultPorts, or that owners can change although nodes always publish the same container port. Internal ports (RCON, REST) and {PUBLIC_PORT_n} values are left out. Both run on drafts only; AUTHORING.md gets the matching rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>🤖 AI Code Review
1. Blocking issues
None that I can identify from the visible code. The logic is sound and the new checks (
splitSettings,portSettings) are well-designed and well-tested.One thing I cannot verify and would like you to confirm: the
worker.gofile (listed in the repo tree but not in the diff) — specifically:newDraftercheck"%s already exists"would fail on a re-run if the folder isn't removed).dockersubprocess (otherwise a cancelled job leaves a container running with the Docker socket mounted).If those are handled, no blockers.
2. Non-blocking suggestions
AUTHORING.mdis read from CWD (os.ReadFile("AUTHORING.md")innewDrafter). This works in the worker (WORKDIR/work) and in the documentedgo runexamples, but breaks if someone invokes the binary from a different directory with-games /path/to/games. You already have-gamesand-schemasflags; consider a-rulesflag or resolving it relative to the binary's directory. This is pre-existing behaviour, not a regression, so it's a low-priority cleanup.isSteamCMDImagehardcodescm2network/steamcmd. If the team ever publishes a self-hosted SteamCMD image (e.g.gbr-builderitself could pull one), the build would treat it as a plain image and skip the Steam-app path. A smallenv varoverride or a comment noting the assumption would save a future debugging session.scanShelldoesn't handle$(…)/ backtick command substitution. If a startup command contains$(cat /server/config), the$triggers the variable-expansion branch,varNamefails to match(, and the character is silently skipped. The net effect is that any${SETTING}inside a command substitution won't be flagged bysplitSettings. This is an acceptable limitation for a lint check, but a brief comment onscanShellnoting what it intentionally doesn't cover (subshells,$(…), process substitution) would help future maintainers understand the scope.bootCheckinvokes itself viaos.Executable()to produce the boot-test payload. This works but is a bit unusual — a directbuildBootTestPayload(gamesDir, id)function call would avoid spawning a process and make the code path easier to unit-test. Not urgent, but worth considering.portSettings— theinternalPortregex is an unanchored substring match. A hypothetical setting namedGameHttpPortwould be silently excluded. Very unlikely in practice, but anchoring to word boundaries or to the end of the key ((?i)(rcon|rest|api|admin|telnet|web|http|metrics)_?(port|$)) would be more precise.builder-image.yml— the workflow has notimeout-minutes. A hungdocker build(e.g. registry unreachable) would sit in the queue indefinitely. A 15-minute timeout is cheap insurance.3. Tests
Coverage for the new pure-logic functions is good (
bootFailure,outsideDirs,splitSettings,portSettings,variantNotes). A few gaps worth filling:scanShell/unwrapShell: no direct unit tests. ThesplitSettingstests cover integration, but a table-driven test forscanShellwith tricky inputs (nested${A:-${B}},A="x $C y"whereCis a text setting,bash -c 'nested "quotes"') would pin down the parser's behaviour and make it safer to extend later.unwrapShell: the negative case (a command that looks likesh -c '…'but contains a single quote inside) isn't tested. The!strings.Contains(m[1], "'")guard means it falls through — confirm that's the intended fallback with a test.build()image-selection loop: the path where all images areimageUnusableand the path where a SteamCMD image has noStartupHintare only exercised end-to-end. A small table test on a helper (if you extract the selection logic) would guard against regressions.4. Overall assessment
This is a well-structured, well-documented feature. The separation of concerns (research → draft → boot → PR) is clean, the new lint checks (
splitSettings,portSettings) are correctly scoped and well-tested, and thedrafterrefactor makes the model conversation reusable without duplicating state. The CI workflow is minimal and appropriate. The main risk area is the hand-rolled shell scanner, but its scope is narrow and the tests cover the important cases. No correctness or security blockers in the visible code; ship it with the minor cleanups above tracked as follow-ups.Automated review by AI Git Bot
🤖 AI Code Review
1. Blocking issues
None found in the visible code. The logic across
build.go,draft.go,draftchecks.go, andresearch.gois sound, and the tests cover the key paths well.One file I cannot verify:
worker.go(present in the repo tree, called frommain.go, but not shown in the diff). Please confirm:WORK_DIR(or uses a fresh subdirectory) between jobs, sincenewDrafterhard-fails ifgames/<id>/already exists.docker runsubprocess (otherwise a cancelled build leaves a container holding the Docker socket).GITEA_TOKENis never written to a file or passed as a CLI arg (visible inps).If those are handled, no blockers.
2. Non-blocking suggestions
builder-image.ymlhas notimeout-minutes. A hungdocker build(registry unreachable,go mod downloadstuck) occupies the runner indefinitely. Addtimeout-minutes: 20to the job.AUTHORING.mdis read from CWD (os.ReadFile("AUTHORING.md")innewDrafter). Works in the Docker image (WORKDIR/work) and in the documentedgo runexamples, but breaks if you invoke the binary from a different directory with-games /path/to/games. Consider resolving it relative to the executable (os.Executable()→ dir →AUTHORING.md) or adding a-rulesflag. Low priority since the worker always runs from/work.internalPortregex is an unanchored substring match ((?i)rcon|rest|api|admin|telnet|web|http|metrics). A hypothetical setting named `WebPortAutomated review by AI Git Bot