feat(builder): documented launch options only, and no game-specific code #14

2026-10-25T21:47:38Z

greg commented

2026-10-25 21:47:38 +00:00

Launch options must be documented. A draft passed an option its server doesn't have. Servers ignore unknown options, so it booted and passed every boot test while its setting did nothing.

build reads the pages research based the variant on, in full, and the drafter rejects any launch option in the startup command that none of them, nor the image's own scripts, mention. The model gets it back to remove or correct.
Shell tools' options (mkdir -p, [ -n ... ]) are skipped; whole-word matching. The check is off without sources.
Checked against a real draft's 11 sources: it flagged only the invented option.

The builder is game-agnostic.

AUTHORING.md (the model's rules), the research prompt and the schema no longer name any game.
The draft prompt no longer includes real templates from the repo; its format example is one invented server, checked against validation and the draft checks.
Comments, help texts, BUILDER.md and test fixtures use invented names and values.
TestBuilderIsGameAgnostic reads every game's name and id from games/ and fails if any appears in the builder's code, tests, rules, schemas or docs.

🤖 Generated with Claude Code

**Launch options must be documented.** A draft passed an option its server doesn't have. Servers ignore unknown options, so it booted and passed every boot test while its setting did nothing. - `build` reads the pages research based the variant on, in full, and the drafter rejects any launch option in the startup command that none of them, nor the image's own scripts, mention. The model gets it back to remove or correct. - Shell tools' options (`mkdir -p`, `[ -n ... ]`) are skipped; whole-word matching. The check is off without sources. - Checked against a real draft's 11 sources: it flagged only the invented option. **The builder is game-agnostic.** - `AUTHORING.md` (the model's rules), the research prompt and the schema no longer name any game. - The draft prompt no longer includes real templates from the repo; its format example is one invented server, checked against validation and the draft checks. - Comments, help texts, `BUILDER.md` and test fixtures use invented names and values. - `TestBuilderIsGameAgnostic` reads every game's name and id from `games/` and fails if any appears in the builder's code, tests, rules, schemas or docs. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

👀 1

git_ai_bot reviewed

2026-10-25 21:49:18 +00:00

git_ai_bot left a comment

🤖 AI Code Review

⚠️ The review feedback was empty or could not be generated.

Automated review by AI Git Bot

## 🤖 AI Code Review ⚠️ *The review feedback was empty or could not be generated.* --- *Automated review by AI Git Bot*

greg added 1 commit 2026-10-25 21:58:55 +00:00

feat(builder): documented launch options only, and no game-specific code

Validate game templates / validate (push) Successful in 20s

Details

Validate game templates / boot-test (push) Skipped

Details

Validate game templates / publish (push) Skipped

Details

8623ba2d7b

Launch options must be documented. A draft passed an option its server
doesn't have; servers ignore unknown options, so it booted and passed every
boot test while its setting did nothing. build now reads the pages research
based the variant on, in full, and the drafter rejects any launch option in
the startup command that none of them, nor the image's own scripts, mention.
Shell tools' options (mkdir -p, [ -n ...]) are skipped; the check is off
without sources.

The builder is game-agnostic:
- AUTHORING.md (the model's rules), the research prompt and the schema
  describe the rules without naming a game.
- The draft prompt no longer includes real templates from the repo. Its
  format example is one invented server (no real command, options, ports or
  app id), checked by TestExampleTemplateFollowsTheRules.
- Comments, help texts, BUILDER.md and test fixtures use invented names and
  values.
- TestBuilderIsGameAgnostic reads every game's name and id from games/ and
  fails if any appears in the builder's code, tests, rules, schemas or docs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

greg force-pushed feat/documented-launch-options from 929cbc31cf to 8623ba2d7b

2026-10-25 21:58:55 +00:00

Compare

greg changed title from ~~feat(builder): launch options must appear in the research sources~~ to feat(builder): documented launch options only, and no game-specific code

2026-10-25 21:58:58 +00:00

git_ai_bot reviewed

2026-10-25 22:00:25 +00:00

git_ai_bot left a comment

🤖 AI Code Review

⚠️ The review feedback was empty or could not be generated.

Automated review by AI Git Bot

## 🤖 AI Code Review ⚠️ *The review feedback was empty or could not be generated.* --- *Automated review by AI Git Bot*

openhands merged commit f1d074bb11 into main

2026-10-25 22:01:37 +00:00

openhands deleted branch feat/documented-launch-options

2026-10-25 22:01:37 +00:00

git_ai_bot reviewed

2026-10-25 22:03:02 +00:00

git_ai_bot left a comment

🤖 AI Code Review

⚠️ The review feedback was empty or could not be generated.

Automated review by AI Git Bot

## 🤖 AI Code Review ⚠️ *The review feedback was empty or could not be generated.* --- *Automated review by AI Git Bot*

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gbreed-public/gbr-games#14